Skip to content

Conversation

@emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Aug 20, 2025

Proposed change

Add blog post on service web API changes

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features for which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Remove stale or deprecated documentation

Checklist

  • I have read and followed the documentation guidelines.
  • I have verified that my changes render correctly in the documentation.

Additional information

Summary by CodeRabbit

  • Documentation
    • Published documentation detailing changes to service API responses across WebSocket and REST endpoints. Action translations are no longer included in these responses; however, legacy action names and descriptions remain available. Instructions provided for retrieving translation data through the frontend API.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025

📝 Walkthrough

Walkthrough

A new documentation file was added to describe the removal of action translations from WebSocket get_services and REST /api/services responses due to incomplete translations, with instructions for fetching translations via frontend/get_translations.

Changes

Cohort / File(s) Summary
Documentation
blog/2025-10-24-service-web-api-changes.md
New blog post documenting removal of action translations from WebSocket and REST API service responses, retention of legacy untranslated action names and descriptions, and guidance for obtaining translations through the frontend interface.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ❓ Inconclusive The pull request description follows the required template structure with all major sections present: a proposed change summary, a properly selected type of change ("Document new or changing features for which there is an existing pull request elsewhere"), and additional information including a link to the relevant core pull request. However, the two checklist items verifying compliance with documentation guidelines and rendering verification remain unchecked, which suggests the author has not yet completed these important verification steps. While the description is mostly complete structurally, the unchecked verification boxes and the somewhat brief proposed change section indicate incomplete due diligence before submission. The author should check the two checklist boxes to confirm they have read the documentation guidelines and verified that the blog post renders correctly in the documentation before this PR is merged. Additionally, consider expanding the "Proposed change" section with more detail about what specific API changes are being documented (e.g., removal of action translations from WebSocket and REST endpoints) to provide better context for reviewers. These clarifications would strengthen the pull request description.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Add blog post on service web API changes" directly and clearly describes the primary change in this pull request, which adds a new documentation file (blog/2025-10-24-service-web-api-changes.md) about service web API modifications. The title is concise, specific, and contains no vague terms or unnecessary noise. It accurately reflects the main objective of the changeset.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch blog_service_web_api_changes

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 67718cd and fe4baed.

📒 Files selected for processing (1)
  • blog/2025-10-24-service-web-api-changes.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • blog/2025-10-24-service-web-api-changes.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - developers-home-assistant
  • GitHub Check: Header rules - developers-home-assistant
  • GitHub Check: Pages changed - developers-home-assistant

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (5)
blog/2025-08-20-service-web-api-changes.md (5)

4-4: Prefer “WebSocket” over “WS” in the title; tighten wording.

Avoid unexplained abbreviations per Microsoft Style Guide and keep the title concise.

Apply this diff:

-title: "Service translations have been removed from WS get_services and REST /api/services"
+title: "Service translations removed from WebSocket get_services and REST /api/services"

10-10: Clarify that inclusion is in the responses and align parallel structure.

Be explicit that they remain in both responses, and mirror WebSocket/REST phrasing.

Apply this diff:

-Legacy untranslated action descriptions and names specified in `services.yaml` are still included both in the WS command and REST endpoint.
+Legacy, untranslated action names and descriptions from `services.yaml` remain in both the WebSocket and REST responses.

14-14: Use imperative tone and expand “WS” to “WebSocket”.

Aligns with Microsoft Style Guide and keeps instructions direct.

Apply this diff:

-Complete action translations can instead be fetched with the WS command `frontend/get_translations`.
+Fetch complete action translations with the WebSocket command `frontend/get_translations`.

16-16: Tighten sentence and resolve grammar flag.

Shorten and remove “which”. The link context makes “core” clear.

Apply this diff:

-For more details, refer to the core [PR 147120](https://github.com/home-assistant/core/pull/147120) which implemented the change.
+For details, see [core PR 147120](https://github.com/home-assistant/core/pull/147120).

7-16: Add effective version to help integrators plan.

Readers need to know from which Home Assistant release this change applies. Consider adding a short sentence indicating the first release containing this change.

Proposed addition (after the first paragraph):

  • This change takes effect in Home Assistant .

Reply with the target version and I can update the wording accordingly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b9af387 and 99a13ba.

📒 Files selected for processing (1)
  • blog/2025-08-20-service-web-api-changes.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
*/**(html|markdown|md)

⚙️ CodeRabbit Configuration File

*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

*/**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

  • Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"

  • Use sentence-style capitalization also in headings.

do not comment on HTML used for icons

Avoid flagging inline HTML for embedding videos in future reviews for this repository.

Files:

  • blog/2025-08-20-service-web-api-changes.md
🪛 LanguageTool
blog/2025-08-20-service-web-api-changes.md

[grammar] ~16-~16: There might be a mistake here.
Context: ...ll/147120) which implemented the change.

(QB_NEW_EN)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (2)
blog/2025-08-20-service-web-api-changes.md (2)

9-9: Expand “WS”, fix parallelism, and use consistent wording (“defined”).

Follow earlier feedback to expand “WS” and align phrasing with Line 7.

-Legacy untranslated action descriptions and names specified in `services.yaml` are still included both in the WS command and REST endpoint.
+Legacy untranslated action descriptions and names defined in `services.yaml` are still included in both the WebSocket command and the REST endpoint.

11-11: Expand “WS” and switch to directive style per Microsoft Style Guide.

Use imperative mood and explicit terminology.

-Complete action translations can instead be fetched with the WS command `frontend/get_translations`.
+Fetch complete action translations using the WebSocket `frontend/get_translations` command.
🧹 Nitpick comments (3)
blog/2025-08-20-service-web-api-changes.md (3)

4-4: Expand “WS” to “WebSocket” and use active voice in title.

Use explicit terminology in titles and prefer active voice for brevity and clarity.

-title: "Service translations have been removed from WS get_services and REST /api/services"
+title: "Service translations removed from WebSocket get_services and REST /api/services"

7-7: Minor clarity and tense tweak for readability.

Keep present tense for ongoing truths and place the primary rationale first.

-Action translations defined in `strings.json` are no longer included in responses from the WebSocket `get_services` command and the REST `/api/services` endpoint because they were incomplete and the Home Assistant frontend did not use them.
+Action translations defined in `strings.json` are no longer included in responses from the WebSocket `get_services` command and the REST `/api/services` endpoint because the Home Assistant frontend does not use them and the translations were incomplete.

13-13: Use “See … for details.” and remove nonessential clause.

Improves style and also addresses the grammar hint from LanguageTool.

-For more details, refer to the core [PR 147120](https://github.com/home-assistant/core/pull/147120) which implemented the change.
+See core [PR 147120](https://github.com/home-assistant/core/pull/147120) for details.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 99a13ba and 08eb002.

📒 Files selected for processing (1)
  • blog/2025-08-20-service-web-api-changes.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
*/**(html|markdown|md)

⚙️ CodeRabbit Configuration File

*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

*/**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

  • Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"

  • Use sentence-style capitalization also in headings.

do not comment on HTML used for icons

Avoid flagging inline HTML for embedding videos in future reviews for this repository.

Files:

  • blog/2025-08-20-service-web-api-changes.md
🪛 LanguageTool
blog/2025-08-20-service-web-api-changes.md

[grammar] ~13-~13: There might be a mistake here.
Context: ...ll/147120) which implemented the change.

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - developers-home-assistant
  • GitHub Check: Header rules - developers-home-assistant
  • GitHub Check: Pages changed - developers-home-assistant
🔇 Additional comments (1)
blog/2025-08-20-service-web-api-changes.md (1)

2-3: No changes needed: authorURL is the standard key
All existing blog posts use authorURL: (no occurrences of author_url:), including this one.

@MartinHjelmare MartinHjelmare merged commit 2a26bd3 into master Oct 24, 2025
5 checks passed
@MartinHjelmare MartinHjelmare deleted the blog_service_web_api_changes branch October 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants